Add "missing description" tag to constant documentation #85836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will have to check the output to review this, but at least a similar message should be added to enums as well then. |
raulsntos
reviewed
Dec 7, 2023
Comment on lines
+1080
to
+1082
| translate( | ||
| "There is currently no description for this constant. Please help us by :ref:`contributing one <doc_updating_the_class_reference>`!" | ||
| ) |
There was a problem hiding this comment.
This should be added to BASE_STRINGS here and in https://github.com/godotengine/godot-editor-l10n/blob/main/scripts/extract_classes.py#L29 for translate to actually work.
There was a problem hiding this comment.
Made a PR for this godotengine/godot-editor-l10n#14
Mickeon
added a commit
to Mickeon/godot-editor-l10n
that referenced
this pull request
Jan 16, 2024
Mickeon
added a commit
to Mickeon/godot
that referenced
this pull request
Jan 16, 2024
Revives godotengine#85836 Co-Authored-By: krysperz2 <106302189+krysperz2@users.noreply.github.com>
|
Superseded by #87259. Thanks for your contribution nevertheless! |
GuybrushThreepwood-GitHub
pushed a commit
to GuybrushThreepwood-GitHub/godot
that referenced
this pull request
Jan 27, 2024
Revives godotengine#85836 Co-Authored-By: krysperz2 <106302189+krysperz2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "There is currently no description available for this constant" tag to documentation of constants