Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding CollisionObject3D::_mouse_enter() and _mouse_exit() from GDExtension #85870

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Dec 6, 2023

Fixes godotengine/godot-cpp#1325

Currently, this code is explicitly calling these virtual methods on a script. This needs to be switched to GDVIRTUAL_CALL() in order to work for both scripts and GDExtension.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 8, 2024
@akien-mga akien-mga merged commit 26ae551 into godotengine:master Jan 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
@dsnopek dsnopek deleted the collision-object-3d-gdextension-virtuals branch July 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants