Correctly enforce minimum window size in editor #85887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
added
bug
enhancement
topic:editor
usability
topic:gui
cherrypick:4.2
|
Also, this PR makes the project manager a bit bigger by default, matching the minimum size of the editor (so it should not make things worse for smaller screens). But the minimum allowed size of the project manager is still smaller. |
Also set the maximum size for the language picked in the project manager.
YuriSizov
force-pushed
the
editor-enforce-min-window
branch
from
1dde110
to
416e594
Compare
bruvzg
approved these changes
Dec 20, 2023
|
Thanks for reviews! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Window's size methods this early doesn't sync the values with the DisplayServer because the main window doesn't have a valid ID yet. So we have to do the sync manually, otherwise the minimum size is not actually enforced.As an extra usability improvement, and the reason why I noticed this issue, I added the upper cap on the language picker popup in the project manager. By default it just takes as much space as possible, which doesn't seem very usable to me. I made it to cap the size at half the screen resolution, but no less than the minimum window size. The result:
I refactored the PM's code related to this a bit and removed some bits which I think we no longer need.