Fix animated tile random start time not scaled to animation duration #86210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤞manifesting cherry pick for 4.2.2🤞 |
kleonc
added
the
cherrypick:4.2
kleonc
force-pushed
the
tilemap-animated-tile-unnormalize-random-start-time
branch
from
7d86964
to
7dfd0c4
Compare
|
Rebased. |
akien-mga
approved these changes
Feb 11, 2024
|
Thanks! |
kleonc
deleted the
tilemap-animated-tile-unnormalize-random-start-time
branch
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TileMap's animated tiles random animation offset passed to the RenderingServer were not scaled to the animation duration, a normalized value (in
0.0..1.0range) were passed instead, see godotengine/godot-docs#8595 (comment) for the issue in action.cc @rakkarage