Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Fix Audio track crossfade in AnimationPlayer does not work #86718

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jan 2, 2024

Cherry-pick from #86715.

This is an exaggeration. The old AnimationPlayer only deleted the caches for the AudioTrack and AnimationPlaybackTrack.

And now that the AudioTrack is properly managed for blending, there should be no need to delete the cache here so clearing AnimationPlaybackTrack is only needed.

@TokageItLab TokageItLab requested a review from a team as a code owner January 2, 2024 16:51
@TokageItLab TokageItLab requested a review from a team January 2, 2024 16:51
@akien-mga akien-mga changed the title Fix Audio track crossfade in AnimationPlayer does not work [4.2] Fix Audio track crossfade in AnimationPlayer does not work Jan 2, 2024
@akien-mga akien-mga added this to the 4.2 milestone Jan 2, 2024
@YuriSizov YuriSizov merged commit 24c0d26 into godotengine:4.2 Jan 15, 2024
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@TokageItLab TokageItLab deleted the audio-cache-fix branch February 14, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants