Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add missing virtual bind to EditorNode3DGizmo(Plugin) #86881

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added bug topic:gdextension cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 6, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 6, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner January 6, 2024 14:43
@AThousandShips AThousandShips requested a review from a team January 6, 2024 14:44
@AThousandShips AThousandShips requested a review from a team as a code owner January 6, 2024 14:46
@AThousandShips AThousandShips changed the title [Editor] Add missing virtual bind to EditorNode3DGizmoPlugin [Editor] Add missing virtual bind to EditorNode3DGizmo(Plugin) Jan 6, 2024
<return type="void" />
<param index="0" name="id" type="int" />
<param index="1" name="secondary" type="bool" />
<description>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate any details on what this should do, as I don't know what it does, the base method isn't exposed so no information is available

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @KoBeWi who added this AFAICT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in #71092
It's called when a user clicks the gizmo and can be used to fetch and store initial values.

@AThousandShips
Copy link
Member Author

There are potentially a few other missing binds across the engine, did a casual search, this one turned up:

GDVIRTUAL2RC(TypedArray<Vector3i>, _structured_text_parser, Array, String)

Will see about another improvement to bind them (that one should probably also be moved into the protected scope)

Method `_begin_handle_action` was not bound
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the specifics of this particular node, but looking at the code, it's clear that these methods were intended to be exposed to GDExtension (it's got the GDVIRTUAL*() and GDVIRTUAL_CALL()) but that the GDVIRTUAL_BIND() was just forgotten.

So, I can't help with the docs, but the functional code looks good!

@akien-mga akien-mga merged commit 880c120 into godotengine:master Jan 11, 2024
15 checks passed
@AThousandShips AThousandShips deleted the gizmo_fix branch January 11, 2024 16:48
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual function EditorNode3DGizmoPlugin::begin_handle_action not registered to ClassDB
4 participants