Add autocompletion to AnimationNode #86888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
requested changes
Feb 11, 2024
There was a problem hiding this comment.
The parameter in AnimationNode is an internal value, and so far I don't feel that we need this that much, since as I commented in #87171 (comment), the other parts of the extended AnimationNode are too inconvenient to make in GDScript.
Also, it might make sense to do this for filter_path, but it will probably soon make no sense to do so, as resourcing filter #76788 will take precedence.
Mickeon
force-pushed
the
autocompletion-AnimationNode
branch
from
7d8c8a4
to
3c371b9
Compare
|
I updated the PR with the above suggestion. The above review may still stand, though. @TokageItLab would you look at this again? |
TokageItLab
approved these changes
Mar 16, 2024
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
Add autocompletion to AnimationNode
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #86799 and #86884
This PR adds autocompletion to AnimationNode's
find_input,get_parameter,set_parameter,set_filter_path, andis_path_filtered.This is in the hopes that it makes working with animation nodes in code a little more tolerable, although I have a feeling this is quite niche.