Fix BasisUniversal ETC RA as RG transcoding #86916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
cherrypick:4.1
|
I don't have a workflow for testing etc2 on a mobile device right now. Maybe the rendering team is able to check in. It looks ok, but I've been burnt not being able to test on a device before. |
Calinou
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Tested locally (Samsung Galaxy Z Fold4), it works as expected.
Testing project: basisu_transcode_1.zip
Built APKs (ARM64 only):
master: basisu_transcode.master.zip- This PR: basisu_transcode.gh-86916.zip
Desktop
For comparison purposes. Texture is applied both as albedo and normal map for easier comparison.
| VRAM Compressed (S3TC) | Basis Universal |
|---|---|
 |
 |
Mobile
| VRAM Compressed (ETC2) |
|---|
 |
| Before | After (this PR) |
|---|---|
 |
 |
fire
approved these changes
Jan 11, 2024
|
Thanks! |
YuriSizov
removed
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
akien-mga
changed the title
BasisUniversal ETC RA as RG transcoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BasisUniversal module was incorrectly set to interpret
RA_AS_RGtextures asETC2_RGBA8, which caused the following error on mobile devices:This PR should fix that issue, though I haven't been able to test it yet.
MRP for testing the changes: basisu_transcode.zip