Add const lvalue ref to core/* container parameters

[Muller-Castro]

Adds const lvalue reference to the core container types specified in the documentation that are declared in function parameters in core/* files

initial: #51156
editor/*: #88368
modules/*: #88915
platform/*: #88971
servers/*: #88972
scene/*: #88974
others: #88975

[Muller-Castro]

Ok I'll leave the virtual methods that are issuing build errors out of this PR and put then in another PR

[AThousandShips]

Or at minimum remove all unrelated changes from other parts, because they make up a lot of it 🙂

[Muller-Castro]

You mean remove all folders except core and remove core's virtual methods that aren't compiling?

[AThousandShips]

Initial glance, will go over properly when the scope has been reduced 🙂

[Muller-Castro]

Those non-core/* are inevitable for all core/* files to build

[AThousandShips]

Will take a look, thank you and sorry for the inconvenience (and you'll get a bonus of more PRs!)

[AThousandShips]

Other than the note below this looks good and safe to me

[AThousandShips]

I need a second eye on this, as it's very core and specific, unsure about possible side effects, they're my only question mark as it were, should be fine but it's so central that possible side effects could be major

It's simply too big a question mark for me alone (not that I should be the only one reviewing this, but marking it as a point of extra attention)

[AThousandShips]

You have a merge commit in your history, please use rebasing instead, do this by:

git reset --hard HEAD^
git rebase -i master
git push --force

[akien-mga]

Sorry for the delay. Looks good to me overall, needs a rebase and then this should be ready to merge if nobody has any outstanding concerns about the change.

[AThousandShips]

I'd like an eye by a core maintainer familiar with the method_ptrcall.h file, just to ensure there's no weirdness with that, otherwise I think this looks good

CC @reduz @dsnopek perhaps

[dsnopek]

The changes in method_ptrcall.h seem fine to me! The const is added to Vector's that we're only reading from.

[akien-mga]

Thanks!