Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix Dummy audio driver initialization issue on WASAPI output device initialization failure #87261

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[3.x] Fix Dummy audio driver initialization issue on WASAPI output device initialization failure #87261

merged 1 commit into from
Jan 17, 2024

Conversation

alessandrofama
Copy link
Contributor

@alessandrofama alessandrofama requested a review from a team as a code owner January 16, 2024 17:44
@akien-mga akien-mga added bug platform:windows topic:audio cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jan 16, 2024
@akien-mga akien-mga added this to the 3.6 milestone Jan 16, 2024
@akien-mga
Copy link
Member

Oh I misread the conflict diff when trying to cherrypick, I see now it was actually the same pattern with a different method name.

@akien-mga akien-mga merged commit 2c5a420 into godotengine:3.x Jan 17, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@alessandrofama alessandrofama deleted the 3.x-wasapi-failed-init branch January 17, 2024 12:49
@akien-mga
Copy link
Member

Cherry-picked for 3.5.4.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:audio
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandrofama @akien-mga