Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform aborted message to 2D matching 3D #87621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryevdokimov
Copy link
Contributor

@ryevdokimov ryevdokimov commented Jan 26, 2024

Related to: #87616

It's in 3D and I think it's useful.

2024-01-26.10-56-59.mp4

@KoBeWi
Copy link
Member

KoBeWi commented Jan 27, 2024

This adds a lot of code for a trivial feature that IMO isn't that useful.
I think it needs a proposal.

@ryevdokimov
Copy link
Contributor Author

It probably could be reduced if some of the functionalities were hard-coded, but I tried to make the code similar to how it was written in 3D and to keep it flexible in case more messages on a timer in the future were required. Fair enough though.

Added: godotengine/godot-proposals#8977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants