[3.x] Fix the documentation of Bone2D::apply_rest
#87737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Micky <66727710+Mickeon@users.noreply.github.com>
akien-mga
changed the title
Bone2D::apply_rest
akien-mga
added
the
cherrypick:3.5
akien-mga
approved these changes
Jan 30, 2024
|
Thanks! |
|
Cherry-picked for 3.5.4. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #85503 -- I checked
git blame, this is how the function has worked since the creation of 2D skeletons.(The Co-Authored-By has been preserved in the commit as the wording ultimately used was given by Mickeon. Really having it be "authored by" makes more sense given the 'story' of the commit, but that'd be metadata forgery...)
This is relevant, but not necessarily cherry-pickable, for all Godot 3.x versions since and including 3.1-stable, and should be cherry-pickable for all versions since 3.2-stable.
(The main thing preventing cherry-picking this commit for 3.1-stable in particular is that the function did not have documentation until 3.2-stable.)