Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GDScriptUtilityCallable return call error when method is invalid #87783

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Make GDScriptUtilityCallable return call error when method is invalid #87783

merged 1 commit into from
Feb 7, 2024

Conversation

AThousandShips
Copy link
Member

Follow-up to:

For completeness, all other callables appear to have proper error reporting when possible

@AThousandShips AThousandShips added this to the 4.3 milestone Jan 31, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner January 31, 2024 13:12
@AThousandShips AThousandShips changed the title Make GDScriptUtilityCallable provide errors on invalid Make GDScriptUtilityCallable provide errors on invalid method Jan 31, 2024
@AThousandShips AThousandShips changed the title Make GDScriptUtilityCallable provide errors on invalid method Make GDScriptUtilityCallable return call error when method is invalid Jan 31, 2024
dalexeev
dalexeev approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The error shouldn't happen (there shouldn't be a way to obtain an invalid utility callable), but anyway thank you for fixing it!

@akien-mga akien-mga merged commit 9cfd6db into godotengine:master Feb 7, 2024
16 checks passed
@AThousandShips AThousandShips deleted the utility_err branch February 7, 2024 10:10
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @akien-mga @dalexeev