Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Add SIGTRAP to the crash handler. #87842

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 1, 2024

Fixes #87718

It's unnecessary for other platforms and not triggered by real crashes, but useful to get trace from OS.crash call.

@bruvzg bruvzg added this to the 4.x milestone Feb 1, 2024
@bruvzg bruvzg requested a review from a team as a code owner February 1, 2024 22:02
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it mostly works as expected.

I can see #61906 partially working: window title is changed and crash backtrace is printed to stdout (and log file), but the window never exits and I don't see the alert appearing like I do on Windows and Linux.

That said, this may just be due to OS::alert() blocking the handler in a different way than on Windows and Linux. I may have to skip OS::alert() on macOS and just open the log file directly with the default program.

image

@bruvzg
Copy link
Member Author

bruvzg commented Feb 2, 2024

That said, this may just be due to OS::alert() blocking the handler in a different way than on Windows and Linux. I may have to skip OS::alert() on macOS and just open the log file directly with the default program.

In case of macOS, OS::alert require event loop to run, otherwise it won't show (or will be unresponsive).

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fully functional with the latest revision of #61906, so this should be good to go.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 6, 2024
@akien-mga akien-mga merged commit bf8814e into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash handler on macOS isn't triggered, even in official editor builds
3 participants