Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation on Android package unique name #88024

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Improve documentation on Android package unique name #88024

merged 1 commit into from
Feb 7, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 6, 2024 •
edited
Loading

  • Document $genname behavior.
  • Mention that changing the package name invalidates existing installations (i.e. new data folder is used, and the app is installed separately instead of updating existing installations).
  • Update to match actual validation and Google Play guidelines.

See https://forum.godotengine.org/t/genname-token-in-export-presets/46280.

@Calinou
Improve documentation on Android package unique name
111908c 
- Document `$genname` behavior.
- Update to match actual validation and Google Play guidelines.
@Calinou Calinou requested a review from a team as a code owner February 6, 2024 17:20
@Calinou Calinou added enhancement documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 6, 2024
@Calinou Calinou added this to the 4.3 milestone Feb 6, 2024
AThousandShips
AThousandShips approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on style

m4gr3d
m4gr3d approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@akien-mga akien-mga merged commit 67234ea into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Mar 11, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 11, 2024
@Calinou Calinou deleted the doc-android-package-unique-name branch March 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @akien-mga @m4gr3d @AThousandShips