SCons: Fix incremental builds breaking when querying the dependency tree from a SCsub #88025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hare the same database
SConscript("some SCsub path") calls create a new context where a relative path
to the .sconsign file is interpreted as being next to the currently executing
SCsub, and not the one at the root. This breaks incremental build detection
because scons can't find the build information of dependent files outside of the
SCsub directory and just rebuilds everything every time.
shana
force-pushed
the
fix-incremental-builds
branch
from
3c0c583
to
0b43b01
Compare
akien-mga
approved these changes
Feb 6, 2024
akien-mga
added
the
cherrypick:4.2
akien-mga
changed the title
|
Thanks! |
akien-mga
added
the
cherrypick:4.1
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm querying the scons dependency tree to calculate some build information in a
SCsub, viaSCons.Node.FS.File.children(). This call causes scons to access the .sconsign database, to lookup the build information up to that point. When this happens on anSCsubinvoked via aSconscript()call, the path to the .sconsign file is interpreted as being relative to the current executingSCsub, not to the top-levelSConstructfile.When this happens, it completely breaks incremental builds, because scons can't find build information in the "local" sconsign file (which is created on the spot with only the local
SCsubbuild information), so scons decides to rebuild everything.I don't know why scons is doing this, given that all other build information is recorded on the top level sconsign file, including the build information related to the executing SCsub, but it is happening. Possibly a scons bug?
This PR sets an absolute path for
SConsignFile, so any queries to the dependency database use the same database file, regardless of local executing SCsub context.Contributed by W4Games ❤️
/cc @akien-mga @mhilbrunner