-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error spam when adding tabs to TabBar
without deselect
#88494
Conversation
Works good for changing the tab amount. The issue can still happen when toggling the tab's disabled property. And it can't be set in the inspector, but we might want to do the same in |
Will fix that later today, thank you! |
c6f926f
to
23a5b1d
Compare
Removed the check for |
`current` was allowed to be `-1` when deselection was disabled, causing errors in other methods when updating the size.
23a5b1d
to
a56c03d
Compare
Thanks! |
Thank you! |
Ensures
current
has a valid value after resizing if deselection is not allowed.The revert marker being visible for the deselect disabled case is a bit annoying and confusing but is a bit more complex to solve, and unsure how it would affect other things with the default values etc., but worth looking into in the future as well.
MRP:
TabMRP.zip
Note how it will print:
When opening the file, and also when resizing the tab bar
This ensures the
current
value is updated to the correct range in this caseEdit: Confirmed that this works on top of: