Remove almost all remaining dependencies of TileMapLayer on TileMap #88966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groud
force-pushed
the
remove_tilemap_layer_dependencies_to_tilemap
branch
2 times, most recently
from
fddc51a
to
54b0f95
Compare
groud
force-pushed
the
remove_tilemap_layer_dependencies_to_tilemap
branch
2 times, most recently
from
985cf64
to
34825ad
Compare
groud
force-pushed
the
remove_tilemap_layer_dependencies_to_tilemap
branch
from
34825ad
to
c17e16a
Compare
Regarding this bugsquad edit, this was a 3.x bug report. Not sure it's fixed there. |
groud
force-pushed
the
remove_tilemap_layer_dependencies_to_tilemap
branch
from
c17e16a
to
787c784
Compare
|
It's just old, the issue is still relevant in Godot 4. |
That makes sense, but the question was more "Is it still relevant in 3.x" |
|
Well, the issue will still exist in 3.x and would require a separate fix. But it's not critical. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the last step before we can expose TileMap layers as individual nodes, as this makes TileMapLayer self-sufficient. Instead of TileMap fetching data from its parent TileMap node, the TileMap nodes sets properties on its children layers.
The TileMap has however to call
set_as_tile_map_internal_nodeto adjust the behavior of the layer. It makes some callbacks (navigation and physics mainly) point towards the TileMap node as a source of the interaction (collision) instead of the layer node itself. It also automatically instantiate a navigation map for layers with index >= 1, and sets a few needed properties. Basically it allows keeping compatibility.This PR should keep full compatibility (and fix self_modulate on TileMap not working, while we are at it).
Bugsquad edit: Fixes #31413
Edit: supersedes #75320