Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Add optional push_meta argument to control how meta underline is drawn. #89024

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 29, 2024

  • Adds option to hide underline or show it on hover for individual meta tags.

Supersede #89000

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm questioning if META_UNDERLINE_NEVER is ever useful or if the behaviour with Images we talked about prior should be addressed, instead.

Like, I want to note you can already choose which meta tag has underlines and which does not, with push_underline. So the extra granularity feels a bit superfluous.

doc/classes/RichTextLabel.xml Show resolved Hide resolved
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review above still stands but I desire to have a long-living love relationship with this feature.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 1, 2024
@akien-mga akien-mga merged commit 8e951fd into godotengine:master Mar 1, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants