Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipper2: Update to 1.3.0 #89025

Merged
merged 1 commit into from
Mar 8, 2024
Merged

clipper2: Update to 1.3.0 #89025

merged 1 commit into from
Mar 8, 2024

Conversation

Chubercik
Copy link
Contributor

@Chubercik Chubercik commented Feb 29, 2024 •
edited
Loading

https://github.com/AngusJohnson/Clipper2/releases/tag/Clipper2_1.3.0

  • Updated COPYRIGHT.txt
  • Updated thirdparty/README.md to be more precise

@Chubercik Chubercik requested a review from a team as a code owner February 29, 2024 23:58
@Chubercik Chubercik marked this pull request as draft March 1, 2024 00:03
@YeldhamDev YeldhamDev added this to the 4.3 milestone Mar 1, 2024
@Chubercik Chubercik marked this pull request as ready for review March 1, 2024 10:18
smix8
smix8 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not encounter a regression for the 2D navmesh baking.

I see that there are multiple fixes to Rect Clipper bugs in the repo that are not part of the 1.3.0 releaes version. Maybe those should be included on top.

@Chubercik
Copy link
Contributor Author

Do you have any specific commit in mind?

From what I understand, unless something's broken we try to use the current stable release - Clipper2's latest is 3 months old already, so I'd assume 1.3.1 is on the horizon. IMO we can go forward with merging unmodified 1.3.0 for now and sync up with 1.3.1 when it becomes available.

@akien-mga akien-mga merged commit 7755079 into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chubercik Chubercik deleted the clipper2-1.3.0 branch March 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@smix8 smix8 smix8 approved these changes

Assignees
No one assigned
Labels
enhancement topic:thirdparty
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Chubercik @akien-mga @smix8 @YeldhamDev