Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lock and group button state when selection changed in CanvasItemEditor #89132

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #89016

Node3D seems not suffered from this issue.

@KoBeWi
Copy link
Member

KoBeWi commented Mar 4, 2024

You could easily supersede the 2D part of #88997 now.

Add a new bool under all_group called has_canvas_item. Set it to true inside if (item) condition and disable buttons based on has_canvas_item (empty selection is handled for free).

@jsjtxietian
Copy link
Contributor Author

Add a new bool under all_group called has_canvas_item. Set it to true inside if (item) condition and disable buttons based on has_canvas_item (empty selection is handled for free).

Yes, I guess I can wait for this to be merged first and then rebase that pr to keep commits seperate.

@akien-mga akien-mga merged commit 72a3172 into godotengine:master Mar 6, 2024
16 checks passed
@jsjtxietian jsjtxietian deleted the lock-update branch March 6, 2024 08:52
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock button sometimes does not update
5 participants