Add text tooltip for TabBar & TabContainer

[4d49]

Closes godotengine/godot-proposals#9252

[YeldhamDev]

LGTM

[akien-mga]

Code looks pretty clean, and the feature makes sense. I'm surprised we didn't have it yet :D

[KoBeWi]

The tooltip overlaps preview of scene tabs:

[Mickeon]

I remember there was some discussion going in the past. Something about tooltips that only repeat the hovered subject being very annoying and superfluous. I wouldn't want to contribute to that by default as by this PR does (and as by KoBeWi's screenshot shows).

[YeldhamDev]

I remember there was some discussion going in the past. Something about tooltips that only repeat the hovered subject being very annoying and superfluous.

I think those tooltips have a place when the tab's text is truncated, but yeah, it currently just shows it no matter what.

[ryevdokimov]

+1 to Mickeon's point. Tooltips will hijack 'ui_cancel' to close the tooltip. Select a node and then have your cursor over a tool mode button w/ the tooltip visible, then press escape (the default) to try to unselect the node, and you'll see what I mean.

I don't have an opinion on that specific behavior, but I do believe that it should be minimized, by not having tooltips showing redundant information scattered around the editor.

[Mickeon]

Point is, regarding this specific PR, the default behavior should be no tooltip at all (in my opinion)

[4d49]

I reworked the code and now tooltips shows tab title only if text is truncated.

[Mickeon]

I think that makes sense, it's desirable and expected.
Are there cases in the editor where the tab title would appear truncated? Struggling to think of any right now, most tabs are not afraid to display their title in full.

[KoBeWi]

I'm not even sure how to make a tab truncated, as tabs simply disappear if they have no space.

[YeldhamDev]

max_tab_width will limit how big a tab can get, and it's used in the editor for scene files with really long names:

[AThousandShips]

The above code needs figuring out

Resolved

[timothyqiu]

The tooltip text should be carried over in TabContainer::move_tab_from_tab_container() so that dragging across different containers work.

The requested changes are made.

[timothyqiu]

Needs a rebase, otherwise looks good.

[4d49]

@timothyqiu done!

[akien-mga]

Thanks!

[Lexpeartha]

Point is, regarding this specific PR, the default behavior should be no tooltip at all (in my opinion)

Also for the record, it doesn't seem possible to disable this behavior if you're using TabContainer since TabBar is built-in so you can't do anything about it. Not sure if this is desired behavior though

[Mickeon]

See:

• Let's get rid of useless tooltips that only display what's already shown godot-proposals#6235

So to me, if it's really just showing the tab's name, it's pretty undesirable and should be fixed.

[kitbdev]

Tooltips are only shown if the tab content is cut off, this only happens if the max_tab_width is set on the TabBar. This follows godotengine/godot-proposals#6235 (comment). To hide it then, the tooltip for each tab can be set to a space as mentioned in the docs for set_tab_tooltip.
But to get this to even happen on a TabContainer, you need to use get_tab_bar() to set the max_tab_width, so you have access to the TabBar and can disable it.