Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PermissionsUtil#requestPermissions(...) to provide the ability to request multiple permissions at a time #89260

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Mar 7, 2024

@m4gr3d m4gr3d added this to the 4.3 milestone Mar 7, 2024
@m4gr3d m4gr3d requested a review from dsnopek March 7, 2024 19:26
@m4gr3d m4gr3d requested a review from a team as a code owner March 7, 2024 19:26
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this PR, but I have tested the nearly identical code in PR GodotVR/godot_openxr_vendors#102 and that definitely works!

The code is "nearly identical" because one is in Java and the other is Kotlin, but it's a straightforward translation. There's some additional clean-up and refactoring in this PR too, which looks good to me.

@akien-mga akien-mga merged commit 694d4f8 into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants