Enforce \n eol for Python writes
#89333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Ensure utf-8 encoding if previously unspecified
akien-mga
approved these changes
Mar 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily created with the intent of fixing a pre-commit hook bug causing eol to change to
CRLFon Windows machines, which was fixed by enforcing\neol on-write incopyright_headers.py. However, realizing that this eol specification isn't really used elsewhere in the repo, in constrast to.gitattributesexpecting it at all times, this branched out to applying that specification to all relevant file writes across every Python script. Additionally, while largly superfluous, this also enforcesutf-8encoding for file writes if previously unspecified.