Defer ActionMapEditor::_action_edited signal to prevent tree updates when tree is blocked.
#89346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
commented
Mar 10, 2024
| @@ -429,6 +429,7 @@ void ActionMapEditor::update_action_list(const Vector<ActionInfo> &p_action_info | |||
| // Update Tree... | |||
|
|
|||
| TreeItem *action_item = action_tree->create_item(root); | |||
| ERR_FAIL_NULL(action_item); | |||
There was a problem hiding this comment.
This should never trigger, added just in case.
There was a problem hiding this comment.
I know this comes from the issue, but there are more potentially crashing spots like that. Kinda odd to handle only this one specifically.
KoBeWi
reviewed
Mar 10, 2024
…s when tree is blocked.
bruvzg
changed the title
item_edited signal when tree updates are blocked.ActionMapEditor::_action_edited signal to prevent tree updates when tree is blocked.
|
Updated to defer |
KoBeWi
approved these changes
May 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #86612, by preventing tree update inside
propagate_mouse_event, but I'm not sure if this is the best fix (tree internal login probably should be changed to be more robust).