Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning when XR shaders are not enabled #89397

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

clayjohn
Copy link
Member

I ran into this warning when trying to repro an XR issue. The warning points you to the "rendering project settings" but the project setting is not in the rendering section, nor is the specific setting mentioned.

@clayjohn clayjohn added enhancement topic:xr cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 11, 2024
@clayjohn clayjohn added this to the 4.3 milestone Mar 11, 2024
@clayjohn clayjohn requested a review from dsnopek March 11, 2024 22:15
@clayjohn clayjohn requested a review from a team as a code owner March 11, 2024 22:15
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Referring to the specific setting is definitely an improvement :-)

@akien-mga akien-mga merged commit 22c20ce into godotengine:master Mar 11, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants