Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output type to DAP output events #89475

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Add output type to DAP output events #89475

merged 1 commit into from
Mar 14, 2024

Conversation

rsubtil
Copy link
Contributor

@rsubtil rsubtil commented Mar 14, 2024

Fixes #89279

Forwards the message output type to DAP, allowing to distinguish between stdout and stderr messages.

@rsubtil rsubtil requested a review from a team as a code owner March 14, 2024 10:57
@rsubtil
Copy link
Contributor Author

rsubtil commented Mar 14, 2024

@dekaravanhoc could you test this and check if it works properly on neovim? I've checked the network packets and they look correct, but from VSCode I can't tell much difference between stdout and stderr messages.

@AThousandShips AThousandShips added this to the 4.x milestone Mar 14, 2024
@rsubtil rsubtil force-pushed the feature-add_message_type_to_dap branch from bae4d68 to 707391a Compare March 14, 2024 11:08
@rsubtil rsubtil force-pushed the feature-add_message_type_to_dap branch from 707391a to da20dcf Compare March 14, 2024 12:17
AThousandShips
AThousandShips approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the signal seems to be used in only one place, and isn't exposed, so the change to the signal is safe

The protocol seems to line up with this change, but would be good to get a second pair of eyes on it too

editor/debugger/debug_adapter/debug_adapter_parser.cpp Outdated Show resolved Hide resolved
editor/debugger/debug_adapter/debug_adapter_protocol.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 14, 2024
@rsubtil rsubtil force-pushed the feature-add_message_type_to_dap branch from da20dcf to b6d1204 Compare March 14, 2024 14:34
@akien-mga akien-mga merged commit 6330246 into godotengine:master Mar 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rsubtil rsubtil deleted the feature-add_message_type_to_dap branch March 14, 2024 22:23
@dekaravanhoc
Copy link

Hey @rsubtil looks good to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Debug Adapter: Console Output should have the "console" category as per specifications
4 participants
@rsubtil @akien-mga @dekaravanhoc @AThousandShips