Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @GDScript documentation #89484

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Update @GDScript documentation #89484

merged 1 commit into from
Mar 14, 2024

Conversation

dalexeev
Copy link
Member

  1. Clarify that assert and preload are keywords and cannot be accessed as Callable (see #86823).
    The latter is not available before 4.3 and should be removed on cherry-pick.
  2. Document the long-standing bug that makes @static_unload useless for now (see online docs).
  3. Add a note about @static_unload location for consistency with @tool and @icon.
  4. Remove unfounded mention of is/is_instance_of() performance.

@dalexeev dalexeev added enhancement topic:gdscript documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 14, 2024
@dalexeev dalexeev added this to the 4.3 milestone Mar 14, 2024
@dalexeev dalexeev requested a review from a team March 14, 2024 15:20
@dalexeev dalexeev requested a review from a team as a code owner March 14, 2024 15:20
AThousandShips
AThousandShips approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style looks good, and trusting you on the factual statements though generally I know them to be valid

@akien-mga akien-mga merged commit 3e773b9 into godotengine:master Mar 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the update-gds-doc branch March 15, 2024 01:16
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dalexeev @akien-mga @AThousandShips