Fix method bindings in FBXDocument by making them virtual in GLTFDocument. #89532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuma
force-pushed
the
fix_fbxdocument_binding
branch
from
bbdb5c5
to
fe772af
Compare
lyuma
force-pushed
the
fix_fbxdocument_binding
branch
from
fe772af
to
8232759
Compare
fire
approved these changes
Mar 16, 2024
akien-mga
approved these changes
Mar 23, 2024
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
Fix method bindings in FBXDocument by making them virtual in GLTFDocument.
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FBXDocument api was not functional in GDScript, because the
_bind_methodsis in GLTFDocument, and C++ had no way to know how to reference the FBXDocument version of these functions.I also added a missing function implementation for
FBXDocument::write_to_filesystem- it was previously not linked.