Make the use of ellipses in menus consistent

[timothyqiu]

This PR removes ellipses when the menu item...

• does not require additional information:
  • executes immediately: Insert Key (Animation track editor)
  • brings settings dialog: Editor Settings, Configure Snap, Edit, etc
  • shows a separate tool/view: Command Palette, Manage Export Templates, Orphan Resource Explorer, About Godot, etc
• embeds submenu: Export As, Set Folder Color, etc

Also added ellipses for...

• delete actions that require user confirmation
• rename actions (even when it's in-place rename as users can still press ESC to cancel)

---

References about the use of ellipses in menu items:

Indicate a command that needs additional information (including a confirmation) by adding an ellipsis at the end of the label.
This doesn't mean you should use an ellipsis whenever an action displays another window only when additional information is required to perform the action. For example, the commands About, Advanced, Help, Options, Properties, and Settings must display another window when clicked, but don't require additional information from the user. Therefore they don't need ellipses. ¹

Append an ellipsis to a menu item’s label when people need to provide additional information before the action can complete. The ellipsis character (…) signals that another view will open in which people can input information or make choices. ²

Footnotes

1. https://learn.microsoft.com/en-us/windows/win32/uxguide/cmd-menus#using-ellipses ↩

2. https://developer.apple.com/design/human-interface-guidelines/menus ↩

[AThousandShips]

I'd say this isn't extremely clear cut, many well established programs use ellipses where you have removed them:

• Export as (gimp, open-office)
• Settings, in various phrasings (open-office, Kate, octave, KeePass, GH Desktop, Signal, Visual Studio, Kdnlive)
• Configure grid/snap/etc. (gimp)
• Help Search (Kdnlive)

And surely others, so I don't think just going by a design document is necessarily what to follow

A few of these were also added recently so let's get a clear decision before we keep going back and forth undoing changes :)

• [Editor] Add missing ellipses to menu options that open dialogs #88436

I'd label this as an enhancement and not a bug as well

[AThousandShips]

My opinion is that what's more important than following some third party design guides is to have a uniform design language, where specific terms or symbols mean specific things, here we have used the ellipses to mean "you need to respond to this in some way", and that's important IMO

Now for "About" it makes sense, but generally I'd say the ellipses are appropriate where they trigger some kind of dialog, or more specifically perhaps, it depends on the question "if I press this, is the operation done?", i.e. does something happen and complete by pressing it, not opening a dialog, or requiring a response, a complete action

[AThousandShips]

I'd say this should be dependent on the track type, some tracks do spawn a menu, like method tracks

[timothyqiu]

This may be the same as "Save", which conditionally pops up a dialog. It does not use ellipses conventionally.

But anyway, adjusting the text based on whether user interaction is needed is always an option :P

[AThousandShips]

I'd say it's different as it's not conditional on if the file is already saved, but on the track type, but good point

[timothyqiu]

Closing. It's too exhausting to come back from time to time to check if a PR from half a year ago needs to be rebased.