Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind constants related to 6DOF joints #89851

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

rburing
Copy link
Member

@rburing rburing commented Mar 24, 2024

This makes physics server GDExtensions able to use the respective enums without workarounds.

I didn't manage to document these, as they are unimplemented in Godot Physics. At this point I think it would be acceptable to bind them without documenting them, but of course suggestions for the documentation are welcome.

cc @mihe

This makes physics server GDExtensions able to use the enums without
workarounds.
Copy link
Contributor

@mihe mihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see them get added. This was on my to-do list somewhere at some point.

I can't speak to the documentation part of it, but the rest seems straight-forward and LGTM.

@akien-mga akien-mga merged commit df6f4ce into godotengine:master Mar 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the bind_6dof_enums branch March 28, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

G6DOF_JOINT_FLAG_MAX (and a few others) is not defined in godot-4.0.2-stable tag
5 participants