Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "clear points" function in Path3D topmenu bar #89933

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Support "clear points" function in Path3D topmenu bar #89933

merged 1 commit into from
Apr 4, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #89903

@jsjtxietian jsjtxietian requested a review from a team as a code owner March 27, 2024 04:41
@jsjtxietian jsjtxietian changed the title Support “clear points” function in Path3D editor Support “clear points” function in Path3D topmenu bar Mar 27, 2024
@timothyqiu timothyqiu added this to the 4.3 milestone Mar 27, 2024
Calinou
Calinou approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 29b3d9e), it works as expeted.

Code looks good to me.

@akien-mga akien-mga changed the title Support “clear points” function in Path3D topmenu bar Support "clear points" function in Path3D topmenu bar Apr 4, 2024
@akien-mga akien-mga merged commit b77ac0a into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the path3d-remove branch April 4, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Path3D editor lacks Clear Points Button like Path2D
4 participants
@jsjtxietian @akien-mga @Calinou @timothyqiu