Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wrapping for begin rotate transformation to bring it in line with Blender. #90098

Merged

Conversation

viksl
Copy link
Contributor

@viksl viksl commented Apr 1, 2024

The original PR which brought the Blender style controls into Godot (Begin Rotate Transformation for rotation) specifically disallowed wrapping for rotation but Blender actually does have the rotation with wrapping so this PR removes the extra branch and brings it in line with Blender's functionality.

Also fixes these:


As a side note, although the wrapping can seem strange to many even in Blender it does have its use. When you want more fine control over the rotation you can quickly move your mouse outside the view to wrap it around to "decrease the sensitivity" (larger radius -> smaller angle difference on input movement).

… this behaviour in Godot disabled it, this commit brings it in line with Blender's functionality.
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not deeply review the implications of this but I like the idea.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. This matches Blender 4.1.1 behavior.

PS: I noticed we're missing the Shift modifier from Blender (when not holding Ctrl), which divides the mouse movement speed by 10 during transformation.

@viksl
Copy link
Contributor Author

viksl commented Jun 16, 2024

@Calinou Thank you so very much!

I'll try to keep the modifier in my mind for the next cycle, thanks!

Secondly, is there a specific rule to the fine controls modifiers which I'm not aware of in Godot, please?
I noticed that some control elements have it when changing values and some don't and it confuses me, I assume since you are pointing it out it does not apply here but if you could just let me know that would be wonderful.

@akien-mga akien-mga merged commit bb8fe43 into godotengine:master Jun 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@viksl viksl deleted the fix-instant-rotation-and-return-wrapping branch June 17, 2024 12:36
@viksl viksl restored the fix-instant-rotation-and-return-wrapping branch June 17, 2024 12:36
@viksl viksl deleted the fix-instant-rotation-and-return-wrapping branch June 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants