Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message when removing only child from GraphNode #90229

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Santoss1809
Copy link
Contributor

@Santoss1809 Santoss1809 commented Apr 4, 2024

Pull Request for issue regarding error thrown on delete of only child of a graph node.

Bugsquad edit:

@Santoss1809 Santoss1809 requested review from a team as code owners April 4, 2024 23:35
scene/gui/graph_node.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga requested a review from Geometror April 5, 2024 06:47
@akien-mga akien-mga added this to the 4.3 milestone Apr 5, 2024
@akien-mga akien-mga changed the title Fix #89695: Error message when removing only child from GraphNode Fix error message when removing only child from GraphNode Apr 5, 2024
@Geometror
Copy link
Member

Thanks for looking into this!
There's just one thing: Please remove the issue reference in your commit message to prevent spamming the issue with reference updates :)

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teacher: I met your student today and confirm this was a top-notch first contribution to an open source project of the scale of Godot ;)

(Also do reach out, I'm interested in your program to get students contributing to open source ;))

@akien-mga
Copy link
Member

Amended the commit to address review feedback.

@akien-mga akien-mga merged commit a37db39 into godotengine:master Apr 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when removing only child from GraphNode
4 participants