Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS Export] Fix adding static libs to the Xcode project. #90379

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 8, 2024

Fixes #90173 (I was not able to fully test it since godot-kotlin-jvm seems to be not functional with current master and never generate usercode.a, but file is created manually it is exported and included to the project).

@bruvzg bruvzg added this to the 4.3 milestone Apr 8, 2024
@bruvzg bruvzg requested a review from a team as a code owner April 8, 2024 08:59
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@akien-mga akien-mga merged commit 0e50807 into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@piiertho
Copy link
Contributor

piiertho commented Apr 8, 2024

Fixes #90173 (I was not able to fully test it since godot-kotlin-jvm seems to be not functional with current master and never generate usercode.a, but file is created manually it is exported and included to the project).

It works, but it requires setting up graal and enabling ios in gradle project.
Will test on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS static library export is broken
3 participants