Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Add support for character code BBCode tag [char=...]. #90405

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 8, 2024

@bruvzg bruvzg added this to the 4.x milestone Apr 8, 2024
@bruvzg bruvzg requested a review from a team as a code owner April 8, 2024 20:18
@KoBeWi
Copy link
Member

KoBeWi commented Apr 9, 2024

This will need to be documented here: https://docs.godotengine.org/en/stable/tutorials/ui/bbcode_in_richtextlabel.html#reference

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly.
I only wonder about the name. Is uni a standard BB code for unicode?

@bruvzg
Copy link
Member Author

bruvzg commented Apr 9, 2024

There's no standard bbcode for it (same is true for a some other tags we use).

@akien-mga
Copy link
Member

Would [char=...] be more explicit to users maybe?

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 12, 2024
@coppolaemilio
Copy link
Member

if there isn't a standard I would go with the full word [unicode=...] or with [char=...] like Akien suggested.
The short versions like [img] instead of [image] seem to only exists if there are html tags with the same name, if not, the full word is used (as far as I can tell, making it up tbh, so feel free to ignore).

@akien-mga
Copy link
Member

Based on the RC discussion, let's go with [char=...] then.

@akien-mga akien-mga changed the title [RTL] Add support for character code bb tag. [RTL] Add support for character code BBCode tag [char]. Apr 15, 2024
@akien-mga akien-mga changed the title [RTL] Add support for character code BBCode tag [char]. [RTL] Add support for character code BBCode tag [char=...]. Apr 15, 2024
@akien-mga akien-mga merged commit 05b76a9 into godotengine:master Apr 15, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants