Fix the initialization order for the iOS driver #90538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Apr 11, 2024
akien-mga
reviewed
Apr 11, 2024
|
Hi are you able to revise the pr? |
|
Changes look good. Could you squash the commits? :) Edit: Done. |
The problem is that we were initializating the main loop (SceneTree) when we were supposed to just set it. Which would cascade into a series of issues, including having the EditorNode being flagged as "inside_tree" and having a tree, before it was supposed to. This meant that some code would assume it was fully initialized, when it was not. And this manifested as the project not being scanned for resources, which meant that during the importing, the resources would not match using the uid path, and produce lots of errors. One line fix
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we were initializating the main loop (SceneTree) when we were supposed to just set it. Which would cascade into a series of issues, including having the EditorNode being flagged as "inside_tree" and having a tree, before it was supposed to.
This meant that some code would assume it was fully initialized, when
it was not. And this manifested as the project not being scanned for
resources, which meant that during the importing, the resources would
not match using the uid path, and produce lots of errors.
This is a merged version of #89684