Rename accessor GLTFType to GLTFAccessorType, fix verbose prints, document GLTFAccessor #90560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #36382 and #89317. The name
type
by itself is too generic and should be avoided.This PR renames GLTFAccessor
get_type
toget_accessor_type
, renames the GLTFType enum to GLTFAccessorType, moves GLTFAccessorType togltf_accessor.h
, and documents all of GLTFAccessor's properties. It also fixes the verbose prints using a duplicate and incorrect_get_type_name
that used lowercase and "float", but the correct values per the GLTF spec are all uppercase and the float one is "SCALAR".For now the old names are still bound for compatibility, but this change will fix these warnings when building C# assemblies the next time we break compatibility and we remove the old method names: