Check for NaN in set_volume_db functions

[aaronp64]

Added check in AudioStreamPlayer, AudioStreamPlayer2D, and AudioStreamPlayer3D set_volume_db functions to prevent setting volume to NaN, and give an error. Using NaN for volume and playing the AudioStreamPlayer could prevent all audio from playing, even from other AudioStreamPlayers.

Fixes #88133

[fire]

What about is_finite()? Like would you also want to block infinities?

[AThousandShips]

Agreed, should check !is_finite otherwise you'll get NaN in several cases

[KoBeWi]

Using infinite numbers does not break anything, only NaNs.

[AThousandShips]

Using infinite numbers does not break anything, only NaNs.

Are you sure? There's no maths there that generates NaN with infinities? I haven't looked at it all but infinities breeds NaN, remember that 0 * inf is NaN as is inf - inf and -inf + inf

[KoBeWi]

I mean I tested what happens when you set volume_db to INF/-INF and it works in all AudioStreamPlayers (i.e. does not permanently break audio).

[AThousandShips]

Then let's keep it NaN and see if something breaks down the line, though I'd prefer to keep it to just finites as it doesn't make sense to have infinites

[akien-mga]

Thanks!