Make seeking animation playback track consider internal seeking #90960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
added
bug
regression
topic:animation
cherrypick:4.2
TokageItLab
force-pushed
the
fix-animation-playback-track-seek
branch
from
ebad103
to
a0f923e
Compare
fire
approved these changes
Apr 30, 2024
AThousandShips
approved these changes
Apr 30, 2024
TokageItLab
force-pushed
the
fix-animation-playback-track-seek
branch
from
6e44230
to
b346e2a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this fixes a problem where playback from the middle of an AnimationPlaybackTrack was not being played that has not worked since 4.0. However, this is not guaranteed to work with AnimationTree, to accomplish that, we need to more rework as I have said some times. For now, it is expected that this PR will make the behavior of AnimationPlaybackTrack the same as in 3.x.
To backport to 4.1 or earlier, a slightly different modification would be required. So this PR code is valid until 4.2.