Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test cases for ImageTexture3D #91233

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

gavenerickson
Copy link
Contributor

Added unit test cases for ImageTexture3d

Note: I believe that I have fixed the code style errors that occurred during my last pull request and have created a branch for this pull request that is separate from my fork's master branch to prevent myself force closing the request again.

Link back to #43440

@gavenerickson gavenerickson requested a review from a team as a code owner April 27, 2024 00:14
@Chaosus
Copy link
Member

Chaosus commented Apr 27, 2024

@Chaosus Chaosus added this to the 4.3 milestone Apr 27, 2024
@AThousandShips AThousandShips changed the title Added unit test cases for ImageTexture3d Add unit test cases for ImageTexture3D Apr 27, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's fix the CI errors and make sure it runs correctly

tests/scene/test_image_texture_3d.h Outdated Show resolved Hide resolved
tests/scene/test_image_texture_3d.h Outdated Show resolved Hide resolved
tests/scene/test_image_texture_3d.h Outdated Show resolved Hide resolved
tests/scene/test_image_texture_3d.h Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Squashed commits and applied review feedback.

@akien-mga akien-mga merged commit badb1b3 into godotengine:master Jun 12, 2024
16 checks passed
@akien-mga
Copy link
Member

akien-mga commented Jun 12, 2024

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants