Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export dialog sizing issue on small devices #91291

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 28, 2024

Fixes #73130

  • Update the min height from 700 to 500 to match the editor's min height of 600
  • Wrap the Resources and Encryption sections of the TabContainer within a ScrollContainer. This prevents the export dialog from trying to resize to fit the tallest of those sections, and make them accessible on small screen devices.

@KoBeWi
Copy link
Member

KoBeWi commented May 5, 2024

Another thing that could be scrollable is error list. It can get quite lengthy 🤔
image

EDIT:
Yeah with default size there is too little space:
image

EDIT2:
Since this tab is scrollable now, the Tree can get a minimum size. It's ridiculously small.
image

@Hicham12312
Copy link

How do I compile this to an apk so i can use it?

@m4gr3d m4gr3d force-pushed the fix_unreachable_export_button_android_editor branch from 401e1d1 to f0f98ff Compare May 13, 2024 08:17
@m4gr3d m4gr3d self-assigned this May 13, 2024
@KoBeWi
Copy link
Member

KoBeWi commented May 15, 2024

The errors are not visible at all now 🙃
ScrollContainer has no size by default, you should probably give it a minimum one.
The file Tree still needs minimum size.

@m4gr3d m4gr3d force-pushed the fix_unreachable_export_button_android_editor branch from f0f98ff to a789983 Compare May 17, 2024 05:39
Fixes godotengine#73130

- Update the min height from `700` to `500` to match the editor's min height of `600`
- Wrap the sections of the `TabContainer` within a `ScrollContainer`. This prevents the export dialog from trying to resize to fit the tallest of those sections, and make them accessible on small screen devices.
@m4gr3d m4gr3d force-pushed the fix_unreachable_export_button_android_editor branch from a789983 to 60a4cc2 Compare May 18, 2024 18:28
@m4gr3d
Copy link
Contributor Author

m4gr3d commented May 18, 2024

Since this tab is scrollable now, the Tree can get a minimum size. It's ridiculously small.

@KoBeWi I've added a min size for the file tree, so it's now visible when the dialog is resized.

Another thing that could be scrollable is error list. It can get quite lengthy

I've reverted the changes to the error list; I couldn't figure out the proper configuration that would get it to both be scrollable, but expand as needed based on its parent's height.
Also making the error list scrollable is not needed to address #73130; the current updates already make the project export dialog usable on small screens even with multiple errors showing.

@akien-mga akien-mga merged commit b5f8f10 into godotengine:master May 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_unreachable_export_button_android_editor branch May 20, 2024 15:18
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release platform:android topic:editor topic:export
Projects
Status: Bad
4 participants