Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EditorFileDialog::popup_file_dialog() to GDScript and GDExtension #91331

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Apr 29, 2024

The EditorFileDialog::popup_file_dialog() function is used through out the editor when showing a file dialog.

This will show the file dialog at the default size and position for file dialogs in the editor, and select the file name if there is a current file.

This PR exposes the function to GDScript and GDExtension so that editor plugins can show file dialogs in a way that's consistent with the rest of the editor.

@dsnopek dsnopek added this to the 4.x milestone Apr 29, 2024
@dsnopek dsnopek requested review from a team as code owners April 29, 2024 19:52
@dsnopek dsnopek requested a review from a team April 29, 2024 19:57
@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 6, 2024
@akien-mga akien-mga merged commit a7c59fe into godotengine:master May 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@dsnopek dsnopek deleted the expose-editor-file-dialog-popup-function branch July 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants