Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code duplication for adding global script class #91379

Merged
merged 1 commit into from
May 1, 2024
Merged

Remove code duplication for adding global script class #91379

merged 1 commit into from
May 1, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 30, 2024

EditorFileSystem and FileSystemDock had same exact code for registering global classes.

@KoBeWi KoBeWi added this to the 4.x milestone Apr 30, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner April 30, 2024 22:27
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 30, 2024
@akien-mga akien-mga merged commit 26738ea into godotengine:master May 1, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the annihilate_them_duplications branch May 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@KoBeWi @akien-mga