Fix no reparent after hover and no move. #91439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajreckof
force-pushed
the
Fix-no-reparent-after-hover-and-no-move-
branch
from
4be19b5
to
9f5e385
Compare
ajreckof
force-pushed
the
Fix-no-reparent-after-hover-and-no-move-
branch
from
9f5e385
to
0bde84f
Compare
|
I tested this PR and everything seems to work fine. My only concern is that I don't think the "hover" node should be selected after a drag&drop. The standard in UI is that after a drag&drop the moved nodes are selected. Some exemples: blender_QePPCSMgn6.mp4 |
|
Yep, if you reparent node, the dropped node should be selected. |
|
Is this still needed after #91265, or fully superseded by that PR? |
|
Probably not, as the issue is fully resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91254
I'm not sure why this was setting selected while it is not selecting it but just putting a mark. The only thing I could see as difference is wether the node is selected at the end of the drag or not so I postponed the selection to the end of the drag. I think my modification made so that
set_selectedactually do the modification to theEditorSelectionwhich make sense but unvoluntarily this was relying on the broken behavior of it not making the modification.Edit : forgot to push