Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileSystemDock thumbnails sometimes not displaying #91471

Merged
merged 1 commit into from
May 11, 2024

Commits on May 2, 2024

  1. Fix FileSystemDock thumbnails sometimes not displaying

    There were (at least) three cases where thumbnails would not display, if they were generated while the FileSystemDock was not visible:
    	- current_path == "Favorites", due to p_path not starting with "Favorites"
    	- current_path == "res://", due to current_path having last "/" trimmed for comparison
    	- current_path pointing to a selected file instead of folder, since it no longer matches p_path's base directory
    
    This change removes the current_path and is_visible_in_tree checks when determining whether to update the file's icon.
    
    Fixes godotengine#90801
    Fixes godotengine#91432
    aaronp64 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    831a085 View commit details
    Browse the repository at this point in the history