Use a full screen triangle for mipmap calculations in mobile renderer #91480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
added
bug
topic:rendering
regression
topic:3d
cherrypick:4.2
RandomShaper
approved these changes
May 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #88786
Fixes: #88585
Fixes: #90818
Fixes: #91474
Regression introduced by #80311. What was happening here is that inside the shader we were expecting to render a full screen triangle. So we expect three points (0, 1, 2) to draw one triangle. Instead we pass an index array to draw a quad. So we draw the triangle with another triangle on top. BUT the triangle on top contains a vertex that is undefined because it results from an out of bound array access. Some hardware seems to just kill that triangle and work correctly (my intel iGPU does this). Other hardware sets that vertex to (0,0,0) (i.e. in the middle of the screen). Since the UVs of the second triangle don't make sense, you end up with that weird triangle floating at the top of the texture.