Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IMA-ADPCM #91492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented May 3, 2024

Now that QOA was added as a WAV compression, it makes sense to do this.

This places most of the IMA-ADPCM related code into #ifndef DISABLE_DEPRECATED blocks, carefully avoiding compatibility breaks.

  • Trying to import WAV as IMA-ADPCM will emit a WARN_DEPRECATED_MSG, suggesting to use QOA instead;
  • If the editor was built with deprecated=no, trying to import IMA-ADPCM will throw an ERR_UNAVAILABLE.

Closes godotengine/godot-proposals#4264

@DeeJayLSP DeeJayLSP requested review from a team as code owners May 3, 2024 02:07
@YeldhamDev YeldhamDev added this to the 4.3 milestone May 3, 2024
@AThousandShips AThousandShips modified the milestones: 4.3, 4.4 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate low-quality/limited IMA-ADPCM compression from the WAV importer
3 participants