Add a project setting to configure the maximum number of timestamps. #91551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
…, with a description and a reference to the setting when the limit is hit and an ERR_FAIL_COND is hit.
m4rr5
force-pushed
the
configure_timestamp_query_elements
branch
from
ba20be0
to
2bb34a4
Compare
Mickeon
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Documentation is fine.
It seems like it was @clayjohn 's idea to make it a project setting. I wonder what he thinks of it now.
As for me, I heavily appreciate the more explicit error message, although I really worry it will be spammed a lot.
akien-mga
approved these changes
Jul 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a description and a reference to the setting when the limit is hit and an ERR_FAIL_COND is hit.
This is a fix for: #91531