Update ConnectDialog::_filter_method_list to be case insensitive for search string
#91598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
May 5, 2024
AThousandShips
approved these changes
May 6, 2024
…search string Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Frozenfire92
force-pushed
the
select-method-search-insensitive
branch
from
9df26b7
to
94e5bad
Compare
akien-mga
changed the title
ConnectDialog::_filter_method_list to be case insensitive for search string
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#9679
This should make it more inline with other search boxes in the editor. Unsure if there is an existing paradigm, or just .to_lower() as I did here